Handle user-specified schema more defensively. #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the isSchema predicate instead of instanceof checks * Create a final `else` case for unexpected results of the _schema variable * Add tests around AS Base constructor to validate previous and new behavior
trevor-scheer
force-pushed
the
trevor/schema-config-errors
branch
from
dc4831e
to
f20c5df
Compare
abernix
approved these changes
Nov 4, 2019
abernix
changed the title
|
Thank you for wrapping this up, @abernix! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isSchemapredicate instead ofinstanceofcheckselsecase for unexpected results of the_schemavariableAddresses the issue that arose in #3381
Taking recommendation from: #3381 (comment)