Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

express, koa: don't continue past playground render #1436

Merged
merged 5 commits into from
Jul 28, 2018

Conversation

wmertens
Copy link
Contributor

Fixes #1420

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@evans evans changed the title server-express: don't continue past playground express, koa: don't continue past playground render Jul 27, 2018
@evans evans merged commit 11abffb into apollographql:master Jul 28, 2018
@evans
Copy link
Contributor

evans commented Jul 28, 2018

@wmertens Thank you so much! Turns out we had the issue in koa too, so I went ahead and made that fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants