test: fix failing integration tests on node@18 (#6350)

Context: nodejs/node#41431 (comment)
apollographql · Apr 28, 2022 · 6cd417c · 6cd417c
1 parent baaac91
commit 6cd417c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -86,7 +86,7 @@ workflows:
               node-version:
                 - "14"
                 - "16"
-                - "17"
+                - "18"
       - "Check for FIXM\x45"
       - Prettier
       - Spell check
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/server/package.json b/packages/server/package.json
@@ -26,8 +26,8 @@
   },
   "dependencies": {
     "@apollo/usage-reporting-protobuf": "^3.3.0",
-    "@apollo/utils.createhash": "^1.0.0",
-    "@apollo/utils.isnodelike": "^1.0.0",
+    "@apollo/utils.createhash": "^1.1.0",
+    "@apollo/utils.isnodelike": "^1.1.0",
     "@apollo/utils.logger": "^1.0.0",
     "@apollo/utils.fetcher": "^1.0.0",
     "@apollographql/graphql-playground-html": "1.6.29",

diff --git a/packages/server/src/__tests__/integration/apolloServerTests.ts b/packages/server/src/__tests__/integration/apolloServerTests.ts
@@ -934,7 +934,8 @@ export function defineIntegrationTestSuiteApolloServerTests(
             const { family, address, port } =
               this.server.address() as AddressInfo;
 
-            if (family !== 'IPv4') {
+            // @ts-expect-error until https://github.com/DefinitelyTyped/DefinitelyTyped/pull/60042
+            if (family !== 'IPv4' && family !== 4) {
               throw new Error(`The family was unexpectedly ${family}.`);
             }
             return new URL(`http://${address}:${port}`).toString();
@@ -1959,7 +1960,8 @@ export function defineIntegrationTestSuiteApolloServerTests(
 
         const { family, address, port } =
           fakeUsageReportingServer.address() as AddressInfo;
-        if (family !== 'IPv4') {
+        // @ts-expect-error until https://github.com/DefinitelyTyped/DefinitelyTyped/pull/60042
+        if (family !== 'IPv4' && family !== 4) {
           throw new Error(`The family was unexpectedly ${family}.`);
         }