change type signature for impl ariadne::Cache#960
Merged
Conversation
fn fetch() and fn display() changed signatures in the latest patch release of ariadne (0.51.0). * `fn fetch(&mut self, file_id: &FileId) -> Result<&ariadne::Source, Box<dyn fmt::Debug + '_>>` --> `fn fetch(&mut self, file_id: &FileId) -> Result<&ariadne::Source, impl fmt::Debug>` * `fn display<'a>(&self, file_id: &'a FileId) -> Option<Box<dyn fmt::Display + 'a>> ` --> `fn display<'a>(&self, file_id: &'a FileId) -> Option<impl fmt::Display + 'a>`
lrlna
commented
Mar 18, 2025
| impl fmt::Display for Path { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| match self { | ||
| Path::SourceFile(source_file) => source_file.path().display().fmt(f), |
Member
Author
There was a problem hiding this comment.
this is adding an extra white space around path for some reason 🤔
so instead of this:
Error: `typeFragment1` contains too much nesting
╭─[overflow.graphql:11:11]
we get this:
Error: `typeFragment1` contains too much nesting
╭─[ overflow.graphql:11:11 ]
Contributor
There was a problem hiding this comment.
I think this is another change in Ariadne. We changed snapshots in router: apollographql/router#7012
goto-bus-stop
added a commit
that referenced
this pull request
Apr 8, 2025
After #960, apollo-rs does not work with ariadne 0.5.0, so we should bump the minimum version to 0.5.1.
goto-bus-stop
added a commit
that referenced
this pull request
Apr 8, 2025
After #960, apollo-rs does not work with ariadne 0.5.0, so we should bump the minimum version to 0.5.1.
This was referenced Apr 23, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fn fetch() and fn display() changed signatures in the latest patch release of ariadne (0.51.0).
fn fetch(&mut self, file_id: &FileId) -> Result<&ariadne::Source, Box<dyn fmt::Debug + '_>>-->fn fetch(&mut self, file_id: &FileId) -> Result<&ariadne::Source, impl fmt::Debug>fn display<'a>(&self, file_id: &'a FileId) -> Option<Box<dyn fmt::Display + 'a>>-->fn display<'a>(&self, file_id: &'a FileId) -> Option<impl fmt::Display + 'a>