Conversation
Contributor
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 2 changed, 0 removedBuild ID: 85abac688091158dfcd28234 URL: https://www.apollographql.com/docs/deploy-preview/85abac688091158dfcd28234 |
gocamille
reviewed
Jan 5, 2026
gocamille
reviewed
Jan 5, 2026
gocamille
reviewed
Jan 5, 2026
gocamille
reviewed
Jan 5, 2026
DaleSeo
commented
Jan 6, 2026
Member
Author
DaleSeo
left a comment
There was a problem hiding this comment.
Thanks so much @gocamille for taking the time to dig into the code and think through the edge cases. 🙏 Looking forward to more reviews from you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #438
Problem
Previously, passing an empty
audiencesarray in the auth config would cause JWT validation to fail. Users expected that an empty array would skip audience validation entirely, but thejsonwebtokenlibrary's default behavior (validate_aud = true) caused tokens to be rejected.Solution
Added an explicit
allow_any_audienceconfiguration option that follows the same pattern as CORS'sallow_any_origin. When set totrue, audience validation is skipped entirely.