Merged
Conversation
Contributor
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 09c6558baec9c5c419753f3d |
Contributor
|
❌ Changeset file missing for PR All changes should include an associated changeset file. |
DaleSeo
reviewed
Dec 11, 2025
Member
DaleSeo
left a comment
DaleSeo
left a comment
There was a problem hiding this comment.
Hey @david-castaneda! Thanks for fixing our distributed trace propagation. The before/after screenshots really show the value! I just have a bit of minor feedback.
Co-authored-by: Dale Seo <5466341+DaleSeo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support propagating
traceparentcontext into newly created spans. Previously, the server ignoredtraceparentheaders from upstream services, breaking distributed tracing across service boundaries.Changes in this PR:
otel_context_middlewarethat extractstraceparentheaders and stores the parent span in request extensions for RMCP handlers to accesscall_toolandlist_toolshandlers to retrieve parent span from extensionsThis fixes mcp-server spans appearing as siblings instead of children of the upstream service trace.
Trace Hierarchy - Before & After
Before
After