-
Notifications
You must be signed in to change notification settings - Fork 45
Telemetry: Trace operations and auth #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry: Trace operations and auth #375
Conversation
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: cd8271762213def9d3dbf916 URL: https://www.apollographql.com/docs/deploy-preview/cd8271762213def9d3dbf916 |
|
❌ Changeset file missing for PR All changes should include an associated changeset file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have minor suggestions and questions. Overall, this looks solid to me!
| http::{Request, StatusCode}, | ||
| }; | ||
| use http::header::{AUTHORIZATION, WWW_AUTHENTICATE}; | ||
| use tower::ServiceExt; // for .oneshot() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! 👍
| use super::*; | ||
|
|
||
| #[tokio::test] | ||
| async fn start_basic_server() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| } | ||
|
|
||
| impl OperationSource { | ||
| #[tracing::instrument] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this include self?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

We were missing traces for the MCP server generating Tools from Operations and performing authorization. This PR also add the HTTP status code to the top level HTTP trace
Trace Missing OAuth Token

Operation traces


