Gt 337 GitHub workflow release finalize #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 3 new, 4 changed, 9 removedBuild ID: 51cb02a820d24e69ed1ec6e4 URL: https://www.apollographql.com/docs/deploy-preview/51cb02a820d24e69ed1ec6e4 |
nicholascioli
approved these changes
Sep 3, 2025
Contributor
nicholascioli
left a comment
nicholascioli
left a comment
There was a problem hiding this comment.
Looks good to me! I left a few nit comments, but feel free to ignore them
Comment on lines
+8
to
+16
| paths-ignore: | ||
| - '.github/**' | ||
| - '.cargo/**' | ||
| - '.direnv/**' | ||
| - '.vscode/**' | ||
| - 'docs/**' | ||
| - 'Cargo.*' | ||
| - 'crates/**/Cargo.*' | ||
| - '*.md' |
Contributor
There was a problem hiding this comment.
Nit: Do we want this to just be paths instead set to rust source files?
Comment on lines
+183
to
+216
| python3 - <<'PY' > CHANGELOG_SECTION.md | ||
| try: | ||
| import os, re, sys, pathlib | ||
| new = os.environ["NEW"] | ||
| old = os.environ["OLD"] | ||
| p = pathlib.Path("CHANGELOG.md") | ||
| if not p.exists(): | ||
| raise FileNotFoundError("CHANGELOG.md not found at repo root") | ||
| text = p.read_text(encoding="utf-8") | ||
|
|
||
| # Find header for the new version | ||
| start = re.search(rf'(?m)^# \[{re.escape(new)}\]', text) | ||
| if not start: | ||
| print(f"::error::Could not find changelog entry for {new}", file=sys.stderr) | ||
| sys.exit(1) | ||
|
|
||
| # Prefer the *specific* previous version header if present; otherwise, next '# ['; else, EOF | ||
| segment = text[start.start():] | ||
| end_old = re.search(rf'(?m)^# \[{re.escape(old)}\]', segment) | ||
| if end_old: | ||
| segment = segment[:end_old.start()] | ||
| else: | ||
| nxt = re.search(r'(?m)^# \[', segment[len('# [' + new + ']'):]) | ||
| if nxt: | ||
| # adjust to absolute end | ||
| segment = segment[: (len('# [' + new + ']') + nxt.start())] | ||
|
|
||
| segment = segment.rstrip() + "\n" | ||
| print(segment) | ||
| except Exception: | ||
| import traceback | ||
| traceback.print_exc() | ||
| sys.exit(1) |
Contributor
There was a problem hiding this comment.
Nit: We might want this to just be a file that it includes and runs vs writing inline. Your choice
Comment on lines
+240
to
+256
| # Try to create; if it already exists, update it | ||
| if ! gh pr create \ | ||
| --base main \ | ||
| --head "$HEAD" \ | ||
| --title "$TITLE" \ | ||
| --draft \ | ||
| --body-file CHANGELOG_SECTION.md \ | ||
| --label release | ||
| then | ||
| num=$(gh pr list --head "$HEAD" --base main --state open --json number -q '.[0].number' || true) | ||
| if [[ -n "$num" ]]; then | ||
| gh pr edit "$num" --title "$TITLE" --body-file CHANGELOG_SECTION.md --add-label release | ||
| else | ||
| echo "::error::Failed to create or find PR from $HEAD to main" | ||
| exit 1 | ||
| fi | ||
| fi |
Contributor
There was a problem hiding this comment.
Nit: This works for now, but it might be more stable as a cargo xtask in the future since bash can be very finicky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalizing the prep release workflow. Adding the following steps: