-
Notifications
You must be signed in to change notification settings - Fork 46
test: adding a basic manual e2e test for mcp server #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7425be7
test: adding a basic manual e2e test for mcp server
alocay 66b2f14
chore: adding missing changeset file
alocay e798b53
Re-run ai style check
alocay 74e6328
Re-run ai style check
alocay 2a43b19
chore: removing exec since it interferes with trap
alocay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ### test: adding a basic manual e2e test for mcp server - @alocay PR #320 | ||
|
|
||
| Adding some basic e2e tests using [mcp-server-tester](https://github.com/steviec/mcp-server-tester). Currently, the tool does not always exit (ctrl+c is sometimes needed) so this should be run manually. | ||
|
|
||
| ### How to run tests? | ||
| Added a script `run_tests.sh` (may need to run `chmod +x` to run it) to run tests. Basic usage found via `./run_tests.sh -h`. The script does the following: | ||
|
|
||
| 1. Builds test/config yaml paths and verifies the files exist. | ||
| 2. Checks if release `apollo-mcp-server` binary exists. If not, it builds the binary via `cargo build --release`. | ||
| 3. Reads in the template file (used by `mcp-server-tester`) and replaces all `<test-dir>` placeholders with the test directory value. Generates this test server config file and places it in a temp location. | ||
| 4. Invokes the `mcp-server-tester` via `npx`. | ||
| 5. On script exit the generated config is cleaned up. | ||
|
|
||
| ### Example run: | ||
| To run the tests for `local-operations` simply run `./run_tests.sh local-operations` | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slight improvement suggestion. It might be nice if
./run_tests.shby default runs all the tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could but the problem is the mcp-server-tester sometimes doesn't exit. This would hang the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking the issue here for future reference. steviec/mcp-server-tester#30