-
Notifications
You must be signed in to change notification settings - Fork 48
[Docs] Re-organizing docs pages #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 9 new, 4 changed, 3 removedBuild ID: d3472aaba544203ff13a385a URL: https://www.apollographql.com/docs/deploy-preview/d3472aaba544203ff13a385a |
DaleSeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the new layout! it’s so much easier to find what I need. 👍
jcaudle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff. I love how you're making this a lot more approachable.
|
cc @DaleSeo (and anyone from @apollographql/graph-tooling team!) -- this PR is ready for official review! I pushed a second iteration based on feedback from y'all and Amanda. As mentioned in the PR description, I'd like to do a full content review for each page and tighten things up in a separate PR. This just sets the stage for the content organization so that we can focus in on each page for content review afterwards. |
DaleSeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for the re-organization! I have just one minor comment.
esilverm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure-wise this is looking a lot better! I think this may need another pass when we add more content but as of right now it looks a lot better and I can find what I need more easily!
|
TY for the reviews! 🙌🏽 I'll merge this tomorrow since it's near the end of my day now and I wanna make sure I'm available for a big docs change like this 👀 |
|
|
||
| The Apollo MCP server supports authorizing clients (e.g., LLMs) in accordance with [the MCP specification](https://modelcontextprotocol.io/specification/2025-06-18/basic/authorization). | ||
|
|
||
| The current implementation passes through OAuth tokens from MCP clients directly to upstream GraphQL APIs. You can read more about [security considerations](/apollo-mcp-server/limitations#oauth-token-passthrough) when using this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The current implementation passes through OAuth tokens from MCP clients directly to upstream GraphQL APIs. You can read more about [security considerations](/apollo-mcp-server/limitations#oauth-token-passthrough) when using this feature. | |
| The current implementation passes through validated OAuth tokens from MCP clients directly to upstream GraphQL APIs. You can read more about [security considerations](/apollo-mcp-server/limitations#oauth-token-passthrough) when using this feature. |
We've had some confusion around the token passthrough, so I think it would be good to call out that the tokens we do pass to the graphql API have been validated by the MCP server using their configured oauth provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've added this note to a separate ticket where we tackle updating the Auth pages
jcaudle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it'll be much easier to navigate. I especially love that you caught the URLs in the README. Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catches on the readme!
Proposal to re-organize docs:
With this PR, I aimed to keep the content as-is and focus on re-organizing and placement only. In a follow-up PR I'd like to do a full content review for each page and tighten things up! This is just the bare minimum PR.
Before
After
TODO