-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generateInputBuilders #5146
Conversation
✅ Deploy Preview for apollo-android-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 🎉
The doc in plugin-configuration.mdx
should be updated with the new option I guess :)
* | ||
* Default: false | ||
*/ | ||
@ApolloExperimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's one case where we could add a @Since
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea but I would only add @since
once the symbol is stable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes good point, makes sense!
Right, we live in that world now. Having this duplication isn't great but you're right, I'll add it there |
Kotlin constructors with default params are nice but when compared to
Builders
, they lack the ability to represent the "absent" case. Builders allow 3 cases:The same code in Kotlin requires wrapping the parameters in
Optional
which is more verbose when there are a lot of parameters (See #4747):This PR brings back builders for those cases