Serialize nested keyFields objects canonically/stably when computing entity IDs
#8860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
force-pushed
the
stringify-nested-keyFields-objects-canonically
branch
from
dcd8a52
to
ee43496
Compare
benjamn
force-pushed
the
stringify-nested-keyFields-objects-canonically
branch
2 times, most recently
from
dd084a7
to
98a2156
Compare
benjamn
force-pushed
the
stringify-nested-keyFields-objects-canonically
branch
from
98a2156
to
927bb52
Compare
|
Superseded by #8996. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still waiting to hear back about a specific reproduction for #8855, but I thought of an edge case where
keyFieldsserialization could depend on the key order of the input objects.