Resolve imported module IDs without Rollup. #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
force-pushed
the
resolve-module-ids-without-rollup
branch
from
a5284fe
to
4638b51
Compare
We don't currently have any external packages that we want to bundle into @apollo/client, so we can get away with considering any non-relative import to be external. The results of this test exactly match the current contents of externalPackages, so it should be safe to remove that Set. This should save us from making mistakes like the one I fixed in #6624, and if we ever do want to bundle something from node_modules into the @apollo/client bundle again, we can easily carve out an exception.
benjamn
force-pushed
the
resolve-module-ids-without-rollup
branch
from
e8410ae
to
f76db47
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more bespoke approach to #6657, fixing #6687 by not relying on Rollup.