[Data masking] Fix issue applying accessor warnings to interface types (

#12130)
apollographql · Nov 15, 2024 · 1e7d009 · 1e7d009
1 parent d10d702
commit 1e7d009
Show file tree

Hide file tree

Showing 3 changed files with 78 additions and 0 deletions.
diff --git a/.changeset/nice-countries-share.md b/.changeset/nice-countries-share.md
@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+Fix error thrown when applying unmask migrate mode warnings on interface types with selection sets that contain inline fragment conditions.
diff --git a/src/core/__tests__/masking.test.ts b/src/core/__tests__/masking.test.ts
@@ -1651,6 +1651,72 @@ describe("maskOperation", () => {
     expect(console.warn).not.toHaveBeenCalled();
   });
 
+  // https://github.com/apollographql/apollo-client/issues/12127
+  test('handles interface types when using @unmask(mode: "migrate")', async () => {
+    using _ = spyOnConsole("warn");
+    const query = gql`
+      query PlaybackStateSubscriberQuery {
+        playbackState {
+          __typename
+          ...PlaybackStateFragment @unmask(mode: "migrate")
+        }
+      }
+
+      fragment PlaybackStateFragment on PlaybackState {
+        item {
+          __typename
+          id
+
+          ... on Track {
+            album {
+              __typename
+              id
+            }
+          }
+
+          ... on Episode {
+            show {
+              __typename
+              id
+            }
+          }
+        }
+      }
+    `;
+
+    const data = maskOperation(
+      {
+        playbackState: {
+          __typename: "PlaybackState",
+          item: {
+            __typename: "Track",
+            id: "1",
+            album: {
+              __typename: "Album",
+              id: "2",
+            },
+          },
+        },
+      },
+      query,
+      new InMemoryCache()
+    );
+
+    expect(data).toEqual({
+      playbackState: {
+        __typename: "PlaybackState",
+        item: {
+          __typename: "Track",
+          id: "1",
+          album: {
+            __typename: "Album",
+            id: "2",
+          },
+        },
+      },
+    });
+  });
+
   test("masks fragments in subscription documents", () => {
     const subscription = gql`
       subscription {

diff --git a/src/core/masking.ts b/src/core/masking.ts
@@ -333,6 +333,13 @@ function addFieldAccessorWarnings(
         return memo;
       }
       case Kind.INLINE_FRAGMENT: {
+        if (
+          selection.typeCondition &&
+          !context.cache.fragmentMatches!(selection, (data as any).__typename)
+        ) {
+          return memo;
+        }
+
         return addFieldAccessorWarnings(
           memo,
           data,