Nullish check devtools.enabled (#12093)

Co-authored-by: Jerel Miller <[email protected]>
apollographql · Nov 11, 2024 · 1765668 · 1765668
1 parent 014b6aa
commit 1765668
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/angry-sheep-smile.md b/.changeset/angry-sheep-smile.md
@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+Fixed a bug when evaluating the devtools flag with the new syntax `devtools.enabled` that could result to `true` when explicitly set to `false`.
diff --git a/.size-limits.json b/.size-limits.json
@@ -1,4 +1,4 @@
 {
-  "dist/apollo-client.min.cjs": 40266,
-  "import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 33060
+  "dist/apollo-client.min.cjs": 40269,
+  "import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 33061
 }
diff --git a/src/core/ApolloClient.ts b/src/core/ApolloClient.ts
@@ -254,7 +254,7 @@ export class ApolloClient<TCacheShape> implements DataProxy {
     this.typeDefs = typeDefs;
     this.devtoolsConfig = {
       ...devtools,
-      enabled: devtools?.enabled || connectToDevTools,
+      enabled: devtools?.enabled ?? connectToDevTools,
     };
 
     if (this.devtoolsConfig.enabled === undefined) {