Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ApplicationContextInitializer instead of SpringApplicationRunListener for better compatibility #978

Merged
merged 1 commit into from
Mar 3, 2018

Conversation

nobodyiam
Copy link
Member

No description provided.

@nobodyiam
Copy link
Member Author

nobodyiam commented Mar 3, 2018

修复 #937 中由于implements了Spring Boot的接口SpringApplicationRunListener,从而导致Spring Boot版本升级后报错的问题。

@codecov-io
Copy link

codecov-io commented Mar 3, 2018

Codecov Report

Merging #978 into master will decrease coverage by 5.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #978      +/-   ##
============================================
- Coverage      53.3%   48.27%   -5.03%     
- Complexity      922     1647     +725     
============================================
  Files           183      360     +177     
  Lines          5228    10054    +4826     
  Branches        520     1012     +492     
============================================
+ Hits           2787     4854    +2067     
- Misses         2227     4844    +2617     
- Partials        214      356     +142
Impacted Files Coverage Δ Complexity Δ
...ring/boot/ApolloApplicationContextInitializer.java 91.3% <100%> (ø) 5 <2> (?)
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0%> (-10.42%) 6% <0%> (-2%)
...work/apollo/portal/spi/ctrip/CtripUserService.java 92.47% <0%> (ø) 9% <0%> (?)
.../apollo/portal/service/PortalDBPropertySource.java 29.41% <0%> (ø) 3% <0%> (?)
...mework/apollo/portal/controller/EnvController.java 50% <0%> (ø) 1% <0%> (?)
.../ctrip/framework/apollo/portal/util/RoleUtils.java 54.54% <0%> (ø) 6% <0%> (?)
...ip/framework/apollo/portal/entity/vo/LockInfo.java 0% <0%> (ø) 0% <0%> (?)
...ollo/metaservice/controller/ServiceController.java 3.57% <0%> (ø) 1% <0%> (?)
...service/service/config/ConfigServiceWithCache.java 76.47% <0%> (ø) 8% <0%> (?)
...llo/portal/spi/ctrip/CtripSsoHeartbeatHandler.java 0% <0%> (ø) 0% <0%> (?)
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81c9e4...05acc04. Read the comment docs.

@nobodyiam nobodyiam merged commit 1e23258 into apolloconfig:master Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants