Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh session & add admin pages entry point #973

Merged
merged 2 commits into from
Feb 24, 2018

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Feb 24, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 24, 2018

Codecov Report

Merging #973 into master will increase coverage by 5.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #973      +/-   ##
===========================================
+ Coverage     48.28%   53.3%   +5.02%     
+ Complexity     1650     922     -728     
===========================================
  Files           360     183     -177     
  Lines         10062    5228    -4834     
  Branches       1012     520     -492     
===========================================
- Hits           4858    2787    -2071     
+ Misses         4847    2227    -2620     
+ Partials        357     214     -143
Impacted Files Coverage Δ Complexity Δ
...o/adminservice/controller/NamespaceController.java
...framework/apollo/portal/entity/model/AppModel.java
...p/framework/apollo/portal/service/ItemService.java
...ramework/apollo/portal/service/ClusterService.java
...apollo/portal/entity/model/NamespaceTextModel.java
...llo/portal/entity/model/NamespaceReleaseModel.java
.../apollo/portal/listener/ConfigPublishListener.java
...apollo/configservice/ConfigServiceApplication.java
...ork/apollo/portal/controller/SignInController.java
.../framework/apollo/openapi/entity/ConsumerRole.java
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5823daa...c21c746. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 50.451% when pulling 9c71307 on lepdou:refresh_session into 7edfb1a on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@nobodyiam nobodyiam merged commit fd3e2e5 into apolloconfig:master Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants