Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConfigChangeContentBuilder update item issue #934

Merged

Conversation

nobodyiam
Copy link
Member

hibernate will persist every changes made to entities during the session, so in ConfigChangeContentBuilder case, we should clone the entity first to not trigger unnecessary writes to the db. Because we will update the dataChangeLastModifiedTime when build is called.

…ion, so in ConfigChangeContentBuilder case, we should clone the entity first to not trigger unnecessary writes to the db
@nobodyiam nobodyiam requested a review from lepdou January 23, 2018 15:54
@codecov-io
Copy link

codecov-io commented Jan 23, 2018

Codecov Report

Merging #934 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #934      +/-   ##
============================================
+ Coverage     46.74%   46.79%   +0.05%     
- Complexity     1539     1542       +3     
============================================
  Files           352      352              
  Lines          9717     9721       +4     
  Branches        963      964       +1     
============================================
+ Hits           4542     4549       +7     
+ Misses         4832     4830       -2     
+ Partials        343      342       -1
Impacted Files Coverage Δ Complexity Δ
...k/apollo/biz/utils/ConfigChangeContentBuilder.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.91% <0%> (+1.22%) 28% <0%> (+1%) ⬆️
...work/apollo/biz/message/DatabaseMessageSender.java 66.66% <0%> (+10.41%) 8% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13eda7c...3fc83f1. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 50.314% when pulling 3fc83f1 on nobodyiam:fix-ConfigChangeContentBuilder-item into 13eda7c on ctripcorp:master.

@lepdou lepdou merged commit 39dc297 into apolloconfig:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants