Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor httputil error stream handling #883

Conversation

nobodyiam
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 50.334% when pulling aec394a on nobodyiam:refactor-httputil-error-handling-merge into f9cb281 on ctripcorp:master.

@codecov-io
Copy link

Codecov Report

Merging #883 into master will decrease coverage by 0.11%.
The diff coverage is 78.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #883      +/-   ##
============================================
- Coverage     46.92%   46.81%   -0.12%     
+ Complexity     1544     1542       -2     
============================================
  Files           352      352              
  Lines          9715     9717       +2     
  Branches        962      963       +1     
============================================
- Hits           4559     4549      -10     
- Misses         4813     4826      +13     
+ Partials        343      342       -1
Impacted Files Coverage Δ Complexity Δ
...com/ctrip/framework/apollo/util/http/HttpUtil.java 78.43% <78.57%> (-7.29%) 7 <0> (ø)
...lo/exceptions/ApolloConfigStatusCodeException.java 0% <0%> (-100%) 0% <0%> (-2%)
...ework/apollo/internals/RemoteConfigRepository.java 83.97% <0%> (-3.21%) 21% <0%> (ø)
...ervice/service/ReleaseMessageServiceWithCache.java 84.52% <0%> (-1.2%) 23% <0%> (-1%)
.../apollo/internals/RemoteConfigLongPollService.java 77.91% <0%> (+1.22%) 28% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9cb281...aec394a. Read the comment docs.

@nobodyiam nobodyiam merged commit 6633f68 into apolloconfig:master Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants