Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use daemon threads for thread pools #795

Merged
merged 1 commit into from
Oct 25, 2017

Conversation

nobodyiam
Copy link
Member

No description provided.

@nobodyiam nobodyiam requested a review from lepdou October 25, 2017 14:09
@coveralls
Copy link

Coverage Status

Coverage remained the same at 50.527% when pulling 0f60cf9 on nobodyiam:use-daemon-threads into ce521b2 on ctripcorp:master.

@codecov-io
Copy link

Codecov Report

Merging #795 into master will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #795   +/-   ##
=========================================
  Coverage     47.04%   47.04%           
  Complexity     1544     1544           
=========================================
  Files           352      352           
  Lines          9682     9682           
  Branches        959      959           
=========================================
  Hits           4555     4555           
  Misses         4790     4790           
  Partials        337      337
Impacted Files Coverage Δ Complexity Δ
...mework/apollo/common/config/RefreshableConfig.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...o/portal/component/AdminServiceAddressLocator.java 67.44% <100%> (ø) 7 <0> (ø) ⬇️
...mework/apollo/portal/component/PortalSettings.java 55% <100%> (ø) 5 <0> (ø) ⬇️
.../apollo/portal/listener/ConfigPublishListener.java 6.52% <100%> (ø) 2 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce521b2...0f60cf9. Read the comment docs.

Copy link
Contributor

@lepdou lepdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@lepdou lepdou merged commit 2bebe10 into apolloconfig:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants