Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConditionalOnProfile and ConditionalOnMissingProfile annotations #733

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

nobodyiam
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #733 into master will increase coverage by 3.62%.
The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #733      +/-   ##
============================================
+ Coverage     47.36%   50.98%   +3.62%     
+ Complexity     1535      812     -723     
============================================
  Files           347      175     -172     
  Lines          9583     4858    -4725     
  Branches        949      468     -481     
============================================
- Hits           4539     2477    -2062     
+ Misses         4708     2185    -2523     
+ Partials        336      196     -140
Impacted Files Coverage Δ Complexity Δ
...rk/apollo/common/condition/OnProfileCondition.java 78.94% <78.94%> (ø) 6 <6> (?)
.../portal/spi/defaultimpl/DefaultUserInfoHolder.java
...p/framework/apollo/portal/api/AdminServiceAPI.java
...configservice/controller/ConfigFileController.java
...rk/apollo/openapi/v1/controller/AppController.java
...o/portal/component/AdminServiceAddressLocator.java
...portal/component/txtresolver/FileTextResolver.java
.../framework/apollo/openapi/entity/ConsumerRole.java
...ip/framework/apollo/portal/entity/po/Favorite.java
...o/configservice/wrapper/DeferredResultWrapper.java
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f05ddb...25b4317. Read the comment docs.

@lepdou lepdou merged commit 9721ba3 into apolloconfig:master Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants