Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc changes #638

Merged
merged 1 commit into from
Jun 12, 2017
Merged

misc changes #638

merged 1 commit into from
Jun 12, 2017

Conversation

nobodyiam
Copy link
Member

  1. add log output to console for config and admin service
  2. remove dev, lpt, tooling logic
  3. add default 2 seconds of initial delay to long polling

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 50.032% when pulling a99894a7454430b3b5a683b0a9217a4cd6916c74 on nobodyiam:misc-change-merge into 58bd26e on ctripcorp:master.

@codecov-io
Copy link

codecov-io commented Jun 10, 2017

Codecov Report

Merging #638 into master will increase coverage by 0.42%.
The diff coverage is 68.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #638      +/-   ##
============================================
+ Coverage     46.54%   46.96%   +0.42%     
- Complexity     1471     1484      +13     
============================================
  Files           342      342              
  Lines          9381     9390       +9     
  Branches        927      926       -1     
============================================
+ Hits           4366     4410      +44     
+ Misses         4682     4657      -25     
+ Partials        333      323      -10
Impacted Files Coverage Δ Complexity Δ
...va/com/ctrip/framework/apollo/util/ConfigUtil.java 81.57% <100%> (+35.63%) 34 <3> (+12) ⬆️
.../apollo/internals/RemoteConfigLongPollService.java 78.37% <16.66%> (-2.61%) 23 <0> (ø)
...ervice/service/ReleaseMessageServiceWithCache.java 86.9% <0%> (+1.19%) 25% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58bd26e...f30ab9c. Read the comment docs.

1. add log output to console for config and admin service
2. remove dev, lpt, tooling logic
3. add default 2 seconds of initial delay to long polling
@nobodyiam nobodyiam force-pushed the misc-change-merge branch from a99894a to f30ab9c Compare June 11, 2017 06:11
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 50.415% when pulling f30ab9c on nobodyiam:misc-change-merge into 58bd26e on ctripcorp:master.

@lepdou lepdou merged commit 32f5fc8 into apolloconfig:master Jun 12, 2017
@nobodyiam nobodyiam deleted the misc-change-merge branch June 12, 2017 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants