Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use guice as apollo-client ioc mechanism #599

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

nobodyiam
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 50.097% when pulling f048baf on nobodyiam:use-guice-as-client-ioc into c219ee8 on ctripcorp:master.

@codecov-io
Copy link

Codecov Report

Merging #599 into master will increase coverage by 0.24%.
The diff coverage is 70.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #599      +/-   ##
============================================
+ Coverage      46.3%   46.54%   +0.24%     
- Complexity     1446     1450       +4     
============================================
  Files           338      338              
  Lines          9243     9238       -5     
  Branches        911      911              
============================================
+ Hits           4280     4300      +20     
+ Misses         4639     4611      -28     
- Partials        324      327       +3
Impacted Files Coverage Δ Complexity Δ
...ork/apollo/internals/AbstractConfigRepository.java 75% <ø> (ø) 6 <0> (ø) ⬇️
...ork/apollo/spring/config/ConfigPropertySource.java 50% <ø> (ø) 3 <0> (ø) ⬇️
...trip/framework/apollo/util/function/Functions.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...apollo/spring/config/PropertySourcesProcessor.java 100% <ø> (ø) 11 <0> (ø) ⬇️
...va/com/ctrip/framework/apollo/util/ConfigUtil.java 45.94% <ø> (ø) 22 <0> (ø) ⬇️
...ework/apollo/spring/util/BeanRegistrationUtil.java 72.72% <ø> (ø) 3 <0> (ø) ⬇️
...pollo/spring/annotation/ApolloConfigRegistrar.java 100% <ø> (ø) 2 <0> (ø) ⬇️
.../spring/config/ConfigPropertySourcesProcessor.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...trip/framework/apollo/internals/DefaultConfig.java 74.39% <ø> (ø) 22 <0> (ø) ⬇️
...framework/apollo/internals/AbstractConfigFile.java 91.3% <ø> (ø) 5 <0> (ø) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c219ee8...f048baf. Read the comment docs.

@lepdou lepdou merged commit bc0e484 into apolloconfig:master Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants