feat: highlight diffs for properties #5282
+139
−99
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,6 +60,7 @@ directive_module.directive('apollodiff', | |
| part.removed ? 'red' : 'grey'; | ||
| span = document.createElement('span'); | ||
| span.style.color = color; | ||
| span.style.display = 'block'; | ||
| pre = part.added ? '+' : | ||
| part.removed ? '-' : ''; | ||
| span.appendChild(document.createTextNode(pre + part.value)); | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,7 @@ function releaseModalDirective($translate, toastr, AppUtil, EventManager, Releas | |
|
|
||
| scope.releaseBtnDisabled = false; | ||
| scope.releaseChangeViewType = 'compareWithPublishedValue'; | ||
| scope.isComparePublished = true; | ||
| scope.releaseComment = ''; | ||
| scope.isEmergencyPublish = false; | ||
|
|
||
|
|
@@ -170,6 +171,9 @@ function releaseModalDirective($translate, toastr, AppUtil, EventManager, Releas | |
|
|
||
| function switchReleaseChangeViewType(type) { | ||
| scope.releaseChangeViewType = type; | ||
| scope.isCompareMaster = type === 'compareWithMasterValue'; | ||
| scope.isComparePublished = type === 'compareWithPublishedValue'; | ||
| scope.isNoCompare = type === 'release'; | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,7 +74,10 @@ function showTextModalDirective(AppUtil) { | |
| transclude: true, | ||
| replace: true, | ||
| scope: { | ||
| text: '=', | ||
| oldStr: '=', | ||
| newStr: '=', | ||
| enableTextDiff: '=' | ||
| }, | ||
| link: function (scope) { | ||
| scope.$watch('text', init); | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -95,14 +95,18 @@ p, td, span { | |
| color: #797979; | ||
| } | ||
|
|
||
| pre { | ||
| white-space: pre-wrap; /* Since CSS 2.1 */ | ||
| white-space: -moz-pre-wrap; /* Mozilla, since 1999 */ | ||
| white-space: -pre-wrap; /* Opera 4-6 */ | ||
| white-space: -o-pre-wrap; /* Opera 7 */ | ||
| word-wrap: break-word; /* Internet Explorer 5.5+ */ | ||
| } | ||
|
|
||
| .pre { | ||
| white-space: pre; | ||
| } | ||
|
|
||
| .hover:hover { | ||
| background: #f5f5f5; | ||
| cursor: pointer | ||
|
|
@@ -1172,4 +1176,17 @@ table th { | |
| #consumer-list .create-btn img { | ||
| width: 16px; | ||
| height: 16px; | ||
| } | ||
|
|
||
| .left-overflow { | ||
| overflow-x: auto; | ||
| text-align: left; | ||
| } | ||
|
|
||
| .table-fixed{ | ||
| table-layout: fixed; | ||
| } | ||
|
|
||
| .block { | ||
| display: block; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <pre class="no-radius pre" id="{{apolloId}}" style="margin:0"> | ||
| <!-- | ||
| ~ Copyright 2024 Apollo Authors | ||
| ~ | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add null check for selectedClusters array.
The code assumes
selectedClusters[0]exists, which could lead to runtime errors if the array is empty.📝 Committable suggestion