Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support grayscale feature for non-properties namespaces(#4316) #4952

Merged
merged 18 commits into from
Sep 20, 2023
Merged

Support grayscale feature for non-properties namespaces(#4316) #4952

merged 18 commits into from
Sep 20, 2023

Conversation

ywy-github
Copy link
Contributor

@ywy-github ywy-github commented Aug 7, 2023

What's the purpose of this PR

Support grayscale feature for non-properties namespaces

Which issue(s) this PR fixes:

Fixes #4316

Brief changelog

  1. Non-properties namespace displays grayscale buttons.
    Modify src/main/resources/static/views/component/namespace-panel-master-tab.html
  2. Non-properties namespace grayscale version displays the configuration Tab and hides the new configuration button.
    Modify src/main/resources/static/views/component/namespace-panel-branch-tab.html
  3. When the non-properties namespace is modified, the key and type cannot be modified and the comment is hidden.
    Modify src/main/resources/static/views/component/item-modal.html
  4. Modify the grayscale version of the Modify configuration dialog, showing modified configuration instead of new configuration.
    Modify src/main/resources/static/scripts/controller/config/ConfigNamespaceController.js

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #4952 (c8b8703) into master (a23b3a8) will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4952      +/-   ##
============================================
+ Coverage     48.86%   48.94%   +0.08%     
- Complexity     1779     1781       +2     
============================================
  Files           348      348              
  Lines         10991    10991              
  Branches       1095     1095              
============================================
+ Hits           5371     5380       +9     
+ Misses         5290     5281       -9     
  Partials        330      330              

see 1 file with indirect coverage changes

@ywy-github
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ywy-github
Copy link
Contributor Author

recheck

@klboke
Copy link
Contributor

klboke commented Aug 8, 2023

image One suggestion is that, although the current functionality should be complete, it is difficult to distinguish between gray and official versions of configurations in non-properties format. It would be helpful if a comparison feature could be added.

@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
@nobodyiam
Copy link
Member

image One suggestion is that, although the current functionality should be complete, it is difficult to distinguish between gray and official versions of configurations in non-properties format. It would be helpful if a comparison feature could be added.

I agree. Currently, there is a comparison feature when releasing the non-properties namespace.

image

@ywy-github
Copy link
Contributor Author

I tried, but I am not familiar with Angular JS, I wanted to add a pop-up modal for comparison, but clicking on it did not respond, tried many ways but still did not solve

@klboke
Copy link
Contributor

klboke commented Sep 10, 2023

I tried, but I am not familiar with Angular JS, I wanted to add a pop-up modal for comparison, but clicking on it did not respond, tried many ways but still did not solve

@ywy-github Is this the issue I already debugged for you? Are there any other issues besides this one

@ywy-github
Copy link
Contributor Author

So far I have written the corresponding method code in the controller, but there are still some problems, I will debug it.

@klboke
Copy link
Contributor

klboke commented Sep 12, 2023

image image
  • Can non-properties format gray configuration be consistent with properties format gray configuration, and achieve the purpose of confirming gray configuration by triggering comparison between gray version and main version through gray release?

Copy link
Contributor

@klboke klboke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klboke klboke requested a review from nobodyiam September 20, 2023 11:09
@klboke klboke merged commit 57cca96 into apolloconfig:master Sep 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support grayscale feature for non-properties namespaces
3 participants