-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support grayscale feature for non-properties namespaces(#4316) #4952
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov Report
@@ Coverage Diff @@
## master #4952 +/- ##
============================================
+ Coverage 48.86% 48.94% +0.08%
- Complexity 1779 1781 +2
============================================
Files 348 348
Lines 10991 10991
Branches 1095 1095
============================================
+ Hits 5371 5380 +9
+ Misses 5290 5281 -9
Partials 330 330 |
I have read the CLA Document and I hereby sign the CLA |
recheck |
apollo-portal/src/main/resources/static/scripts/controller/config/ConfigNamespaceController.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/controller/config/ConfigNamespaceController.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/views/component/item-modal.html
Outdated
Show resolved
Hide resolved
I tried, but I am not familiar with Angular JS, I wanted to add a pop-up modal for comparison, but clicking on it did not respond, tried many ways but still did not solve |
@ywy-github Is this the issue I already debugged for you? Are there any other issues besides this one |
So far I have written the corresponding method code in the controller, but there are still some problems, I will debug it. |
apollo-portal/src/main/resources/static/scripts/directive/release-modal-directive.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/views/component/release-modal.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
Support grayscale feature for non-properties namespaces
Which issue(s) this PR fixes:
Fixes #4316
Brief changelog
Modify src/main/resources/static/views/component/namespace-panel-master-tab.html
Modify src/main/resources/static/views/component/namespace-panel-branch-tab.html
Modify src/main/resources/static/views/component/item-modal.html
Modify src/main/resources/static/scripts/controller/config/ConfigNamespaceController.js
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.I have read the CLA Document and I hereby sign the CLA