Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support grayscale feature for non-properties namespaces(#4316) #4951

Closed
wants to merge 1 commit into from
Closed

Conversation

ywy-github
Copy link
Contributor

@ywy-github ywy-github commented Aug 6, 2023

What's the purpose of this PR

Support grayscale feature for non-properties namespaces

Which issue(s) this PR fixes:

Fixes #4316

Brief changelog

  1. Non-properties namespace displays grayscale buttons.
    Modify src/main/resources/static/views/component/namespace-panel-master-tab.html
  2. Non-properties namespace grayscale version displays the configuration Tab and hides the new configuration button.
    Modify src/main/resources/static/views/component/namespace-panel-branch-tab.html
  3. When the non-properties namespace is modified, the key and type cannot be modified and the comment is hidden.
    Modify src/main/resources/static/views/component/item-modal.html
  4. Modify the grayscale version of the Modify configuration dialog, showing modified configuration instead of new configuration.
    Modify src/main/resources/static/scripts/controller/config/ConfigNamespaceController.js

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

github-actions bot commented Aug 6, 2023

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


ywy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #4951 (48059b5) into master (99b76dc) will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4951      +/-   ##
============================================
+ Coverage     48.41%   48.50%   +0.09%     
- Complexity     1725     1728       +3     
============================================
  Files           346      346              
  Lines         10836    10836              
  Branches       1080     1080              
============================================
+ Hits           5246     5256      +10     
+ Misses         5265     5258       -7     
+ Partials        325      322       -3     

see 5 files with indirect coverage changes

@ywy-github
Copy link
Contributor Author

recheck

@ywy-github ywy-github closed this Aug 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support grayscale feature for non-properties namespaces
2 participants