refactor(apollo-biz): Use constructor injection instead of field injection #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md
Codecov Report
@@ Coverage Diff @@
## master #4826 +/- ##
============================================
+ Coverage 48.16% 48.41% +0.25%
- Complexity 1719 1721 +2
============================================
Files 346 346
Lines 10772 10819 +47
Branches 1076 1076
============================================
+ Hits 5188 5238 +50
+ Misses 5262 5259 -3
Partials 322 322
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nobodyiam
reviewed
Apr 1, 2023
...o-portal/src/main/java/com/ctrip/framework/apollo/portal/service/PortalDBPropertySource.java
Outdated
Show resolved
Hide resolved
|
Please also help to fix the conflict. |
…polloconfig#4823) * add tech-support-qq-4.png * Update README.md * Enhance the user experience in the scenario of submitting duplicate keys * Modify the key-value conflict exception prompt, adjust the code style * test(apollo-biz): Correct the test semantics of the test case in ItemSetControllerTest * test(apollo-biz): Optimize the test case for ItemSetControllerTest * test(apollo-biz): Optimize the test case for ItemSetControllerTest * test(apollo-biz): Optimize the test case for ItemSetControllerTest --------- Co-authored-by: Jason Song <[email protected]>
* add tech-support-qq-4.png * Update README.md * Enhance the user experience in the scenario of submitting duplicate keys * Modify the key-value conflict exception prompt, adjust the code style * refactor(apollo-biz): Refactor the code related to ReleaseMessage * refactor(apollo-biz): Refactor the code related to ReleaseMessage * test(apollo-admin): Optimize the test case * test(apollo-admin): Optimize the test case --------- Co-authored-by: Jason Song <[email protected]>
ok |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
motivation