Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIDC logout unnecessary redirect #4773

Merged
merged 3 commits into from
Mar 4, 2023

Conversation

vdiskg
Copy link
Contributor

@vdiskg vdiskg commented Mar 4, 2023

What's the purpose of this PR

  1. remove the unnecessary redirect
  2. add debug log for oidc login

Which issue(s) this PR fixes:

Fixes #4714

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@vdiskg vdiskg force-pushed the fix-oidc-logout-url branch from a9770c8 to 240c39f Compare March 4, 2023 04:58
@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #4773 (92c4924) into master (b2e7eed) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4773      +/-   ##
============================================
- Coverage     47.39%   47.26%   -0.14%     
+ Complexity     1660     1657       -3     
============================================
  Files           346      346              
  Lines         10662    10683      +21     
  Branches       1058     1063       +5     
============================================
- Hits           5053     5049       -4     
- Misses         5301     5328      +27     
+ Partials        308      306       -2     
Impacted Files Coverage Δ
...lo/portal/spi/configuration/AuthConfiguration.java 8.27% <0.00%> (-0.07%) ⬇️
...i/oidc/OidcAuthenticationSuccessEventListener.java 0.00% <0.00%> (ø)
...work/apollo/portal/spi/oidc/OidcLogoutHandler.java 0.00% <ø> (ø)
...framework/apollo/openapi/entity/ConsumerAudit.java 42.42% <0.00%> (-6.07%) ⬇️
...mework/apollo/openapi/service/ConsumerService.java 56.92% <0.00%> (-1.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vdiskg vdiskg requested a review from nobodyiam March 4, 2023 05:11
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 9bed634 into apolloconfig:master Mar 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oidc登陆用户显示错误
2 participants