Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to custom service uri when use database-discovery #4743

Merged
merged 4 commits into from
Feb 26, 2023

Conversation

Anilople
Copy link
Contributor

What's the purpose of this PR

Add more document about database-discovery in #4595

Which issue(s) this PR fixes:

None

Brief changelog

Tell users how to custom service uri like they do with eureka.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@Anilople Anilople added the area/document Category issues or prs related to document. label Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #4743 (5f373cc) into master (0bf1028) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4743      +/-   ##
============================================
- Coverage     47.17%   47.14%   -0.04%     
+ Complexity     1658     1655       -3     
============================================
  Files           349      349              
  Lines         10691    10691              
  Branches       1062     1062              
============================================
- Hits           5044     5040       -4     
- Misses         5339     5345       +6     
+ Partials        308      306       -2     
Impacted Files Coverage Δ
...framework/apollo/openapi/entity/ConsumerAudit.java 42.42% <0.00%> (-6.07%) ⬇️
...mework/apollo/openapi/service/ConsumerService.java 56.92% <0.00%> (-1.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Anilople Anilople requested a review from nobodyiam February 26, 2023 11:13
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 2dcbc1d into apolloconfig:master Feb 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/document Category issues or prs related to document.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants