Enable login authentication for eureka #4663
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4663 +/- ##
============================================
- Coverage 47.16% 47.13% -0.03%
Complexity 1647 1647
============================================
Files 347 347
Lines 10643 10660 +17
Branches 1057 1060 +3
============================================
+ Hits 5020 5025 +5
- Misses 5321 5331 +10
- Partials 302 304 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @Value("${apollo.eureka.server.security.username}") | ||
| private String username; | ||
| @Value("${apollo.eureka.server.security.password}") | ||
| private String password; |
There was a problem hiding this comment.
How about let user can config eureka's username and password in configdb?
- only config once even when scale configservice
but the password will save in configdb
There was a problem hiding this comment.
This is a good idea! Storing the username/password in the DB makes it consistent among multiple config services.
The only issue here is apollo.eureka.server.security.enabled, it's hard to read it from DB as it is used in ConditionalOnProperty, which is triggered before the database initialization phase.
There was a problem hiding this comment.
@Anilople I changed the implementation a little and the apollo.eureka.server.security related items could be configured in the configdb, please help to take a look.
There was a problem hiding this comment.
How it work?...
Are there some methods read data the from configdb?...
There was a problem hiding this comment.
The BizConfig would put all the ServerConfig properties to the Spring environment. It won't work for ConditionalOnProperty as it's initiated later than the ConditionalOnProperty processing so I put the if (eurekaSecurityEnabled) check in the method.
There was a problem hiding this comment.
It works.
When I change ServerConfig in configdb
then try to access http://localhost:8080/eureka/apps/APOLLO-CONFIGSERVICE
it need auth as expect.
nobodyiam
force-pushed
the
eureka-server-security
branch
2 times, most recently
from
884541c to
fd96c72
Compare
...rc/main/java/com/ctrip/framework/apollo/configservice/ConfigServerEurekaServerConfigure.java
Show resolved
Hide resolved
| @Value("${apollo.eureka.server.security.username}") | ||
| private String username; | ||
| @Value("${apollo.eureka.server.security.password}") | ||
| private String password; |
There was a problem hiding this comment.
How it work?...
Are there some methods read data the from configdb?...
nobodyiam
force-pushed
the
eureka-server-security
branch
from
10e72ca to
af7e860
Compare
| @Value("${apollo.eureka.server.security.username}") | ||
| private String username; | ||
| @Value("${apollo.eureka.server.security.password}") | ||
| private String password; |
There was a problem hiding this comment.
It works.
When I change ServerConfig in configdb
then try to access http://localhost:8080/eureka/apps/APOLLO-CONFIGSERVICE
it need auth as expect.
nobodyiam
force-pushed
the
eureka-server-security
branch
from
af7e860 to
6ae389f
Compare
What's the purpose of this PR
Enable login authentication for eureka
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.