Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix markdown code blocks by change 4 back quote to 3 back quote #4631

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

hxpdong
Copy link
Contributor

@hxpdong hxpdong commented Nov 6, 2022

I have read the CLA Document and I hereby sign the CLA

What's the purpose of this PR

Change ```` to ```

Which issue(s) this PR fixes:

Fixes #4629

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Sorry, something went wrong.

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@hxpdong
Copy link
Contributor Author

hxpdong commented Nov 6, 2022

I have read the CLA Document and I hereby sign the CLA

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #4631 (c7b3fb1) into master (821c855) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4631   +/-   ##
=========================================
  Coverage     47.16%   47.16%           
  Complexity     1649     1649           
=========================================
  Files           347      347           
  Lines         10644    10644           
  Branches       1057     1057           
=========================================
  Hits           5020     5020           
  Misses         5320     5320           
  Partials        304      304           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hxpdong
Copy link
Contributor Author

hxpdong commented Nov 6, 2022

I hope that I don't miss anything

@mghio
Copy link
Contributor

mghio commented Nov 8, 2022

All ```` key word in .md file collected in md.log, I collect them by run

grep -n "\`\{4\}" $(find . -type f -name "*.md") > md.log

Please check for any omissions, thanks.

@hxpdong
Copy link
Contributor Author

hxpdong commented Nov 8, 2022

All ```` key word in .md file collected in md.log, I collect them by run

grep -n "\`\{4\}" $(find . -type f -name "*.md") > md.log

Please check for any omissions, thanks.

Thanks a lots, I use this command and file md.log show as below:
image

I think that I didn't miss anything when I modify ```` to ```.
Thank a lots!

@hxpdong
Copy link
Contributor Author

hxpdong commented Nov 8, 2022

All ```` key word in .md file collected in md.log, I collect them by run

grep -n "\`\{4\}" $(find . -type f -name "*.md") > md.log

Please check for any omissions, thanks.

Thanks a lots, I use this command and file md.log show as below: image

I think that I didn't miss anything when I modify ```` to ```. Thank a lots!

Oh, I have a error in this command, I fixed this and result as below:
image

@Anilople
Copy link
Contributor

Anilople commented Nov 8, 2022

Please change the pr's title to more readable.

For example:

  • docs: fix markdown code blocks by change 4 back quote to 3 back quote

@hxpdong hxpdong changed the title Issuse #4629 resolved docs: fix markdown code blocks by change 4 back quote to 3 back quote Nov 8, 2022
@hxpdong
Copy link
Contributor Author

hxpdong commented Nov 8, 2022

Please change the pr's title to more readable.

For example:

  • docs: fix markdown code blocks by change 4 back quote to 3 back quote

Yes, thanks! I changed it.

Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anilople Anilople merged commit b435050 into apolloconfig:master Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix document markdown Lightweight Markup Languages code blocks back quote
4 participants