Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test in apollo-biz #4618

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

anantdahiya8
Copy link
Contributor

@anantdahiya8 anantdahiya8 commented Oct 27, 2022

What's the purpose of this PR

Fix flaky junit test in apollo-biz

Which issue(s) this PR fixes:

#4617

Brief changelog

HashMap does not guarantee the order of the elements which can cause the junit test case to fail, hence using a LinkedHashMap

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Oct 27, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #4618 (3673176) into master (d849c02) will not change coverage.
The diff coverage is n/a.

❗ Current head 3673176 differs from pull request most recent head 65ceabf. Consider uploading reports for the commit 65ceabf to get more accurate results

@@            Coverage Diff            @@
##             master    #4618   +/-   ##
=========================================
  Coverage     47.23%   47.23%           
  Complexity     1649     1649           
=========================================
  Files           347      347           
  Lines         10631    10631           
  Branches       1053     1053           
=========================================
  Hits           5022     5022           
  Misses         5306     5306           
  Partials        303      303           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anantdahiya8
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 3c6baa4 into apolloconfig:master Oct 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants