feature: A user-friendly config management page for apollo portal #4592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
webSue
changed the title
|
Need to resolve code conflicts |
|
Please use the apollo code style for format the codes. |
klboke
reviewed
Sep 30, 2022
...ortal/src/main/java/com/ctrip/framework/apollo/portal/controller/ServerConfigController.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4592 +/- ##
============================================
+ Coverage 46.38% 46.43% +0.05%
- Complexity 1563 1565 +2
============================================
Files 331 332 +1
Lines 10360 10367 +7
Branches 1043 1043
============================================
+ Hits 4805 4814 +9
Misses 5259 5259
+ Partials 296 294 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
klboke
reviewed
Oct 8, 2022
apollo-portal/src/main/resources/static/scripts/controller/ConfigController.js
Outdated
Show resolved
Hide resolved
...ortal/src/main/java/com/ctrip/framework/apollo/portal/controller/ServerConfigController.java
Outdated
Show resolved
Hide resolved
...ortal/src/main/java/com/ctrip/framework/apollo/portal/controller/ServerConfigController.java
Outdated
Show resolved
Hide resolved
...ortal/src/main/java/com/ctrip/framework/apollo/portal/controller/ServerConfigController.java
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/api/AdminServiceAPI.java
Outdated
Show resolved
Hide resolved
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/ServerConfigService.java
Outdated
Show resolved
Hide resolved
klboke
reviewed
Oct 8, 2022
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/ServerConfigService.java
Outdated
Show resolved
Hide resolved
klboke
reviewed
Oct 13, 2022
...ortal/src/main/java/com/ctrip/framework/apollo/portal/controller/ServerConfigController.java
Outdated
Show resolved
Hide resolved
...ortal/src/main/java/com/ctrip/framework/apollo/portal/controller/ServerConfigController.java
Outdated
Show resolved
Hide resolved
|
功能验收 OK， @nobodyiam 可以帮忙确认下么 |
|
LGTM |
klboke
previously approved these changes
Oct 18, 2022
nobodyiam
reviewed
Oct 19, 2022
apollo-portal/src/main/resources/static/scripts/controller/ConfigController.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/controller/ConfigController.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/services/ServerConfigService.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/services/ServerConfigService.js
Outdated
Show resolved
Hide resolved
|
@nobodyiam The code has been modified |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
开源之夏2022 系统配置管理模块开发
Which issue(s) this PR fixes:
Fixes #
原系统参数页面用户不友好，无法查看所有支持的配置信息等
Brief changelog
新的系统参数页面，支持portalDB中所有配置项的显示，支持编辑功能，若key存在则覆盖，不存在则新增。新增配置按钮+可使用filter过滤查找配置