Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix openapi item with url illegalKey 400 error #4549

Merged
merged 9 commits into from
Sep 11, 2022

Conversation

AbnerHuang2
Copy link
Contributor

What's the purpose of this PR

fix openapi item with url illegalKey 400 error

Which issue(s) this PR fixes:

Fixes #4447

Brief changelog

get/update/delete the item key with / \ or start with . will encode key by encodeItems API, otherwise, it will act like old way.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Merging #4549 (f5f397b) into master (70791c8) will decrease coverage by 0.01%.
The diff coverage is 39.13%.

@@             Coverage Diff              @@
##             master    #4549      +/-   ##
============================================
- Coverage     53.31%   53.29%   -0.02%     
- Complexity     2707     2710       +3     
============================================
  Files           494      495       +1     
  Lines         15416    15438      +22     
  Branches       1599     1599              
============================================
+ Hits           8219     8228       +9     
- Misses         6637     6651      +14     
+ Partials        560      559       -1     
Impacted Files Coverage Δ
...apollo/adminservice/controller/ItemController.java 7.14% <0.00%> (-0.15%) ⬇️
...k/apollo/openapi/v1/controller/ItemController.java 12.19% <0.00%> (-2.96%) ⬇️
...p/framework/apollo/portal/api/AdminServiceAPI.java 12.95% <0.00%> (-0.14%) ⬇️
...p/framework/apollo/portal/service/ItemService.java 46.32% <0.00%> (-0.53%) ⬇️
.../apollo/openapi/client/url/OpenApiPathBuilder.java 96.49% <100.00%> (+0.19%) ⬆️
...ctrip/framework/apollo/openapi/utils/UrlUtils.java 100.00% <100.00%> (ø)
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0.00%> (-8.34%) ⬇️
...ework/apollo/internals/RemoteConfigRepository.java 88.34% <0.00%> (+3.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit e690e65 into apolloconfig:master Sep 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openapi请求如果key是a.bS/TT/AT,则报404错误
4 participants