-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix openapi item with url illegalKey 400 error #4549
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4549 +/- ##
============================================
- Coverage 53.31% 53.29% -0.02%
- Complexity 2707 2710 +3
============================================
Files 494 495 +1
Lines 15416 15438 +22
Branches 1599 1599
============================================
+ Hits 8219 8228 +9
- Misses 6637 6651 +14
+ Partials 560 559 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mghio
reviewed
Sep 3, 2022
...service/src/main/java/com/ctrip/framework/apollo/adminservice/controller/ItemController.java
Outdated
Show resolved
Hide resolved
mghio
reviewed
Sep 3, 2022
...-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/url/OpenApiPathBuilder.java
Outdated
Show resolved
Hide resolved
mghio
reviewed
Sep 3, 2022
...-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/url/OpenApiPathBuilder.java
Outdated
Show resolved
Hide resolved
mghio
reviewed
Sep 3, 2022
apollo-openapi/src/main/java/com/ctrip/framework/apollo/openapi/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
mghio
reviewed
Sep 3, 2022
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/ItemService.java
Outdated
Show resolved
Hide resolved
mghio
reviewed
Sep 3, 2022
...lo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java
Outdated
Show resolved
Hide resolved
nobodyiam
requested changes
Sep 4, 2022
...service/src/main/java/com/ctrip/framework/apollo/adminservice/controller/ItemController.java
Outdated
Show resolved
Hide resolved
...-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/url/OpenApiPathBuilder.java
Outdated
Show resolved
Hide resolved
...-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/url/OpenApiPathBuilder.java
Outdated
Show resolved
Hide resolved
...openapi/src/test/java/com/ctrip/framework/apollo/openapi/client/ApolloOpenApiClientTest.java
Outdated
Show resolved
Hide resolved
...lo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java
Outdated
Show resolved
Hide resolved
...lo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java
Outdated
Show resolved
Hide resolved
...lo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java
Outdated
Show resolved
Hide resolved
nobodyiam
requested changes
Sep 4, 2022
...service/src/main/java/com/ctrip/framework/apollo/adminservice/controller/ItemController.java
Show resolved
Hide resolved
...lo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java
Outdated
Show resolved
Hide resolved
apollo-common/src/main/java/com/ctrip/framework/apollo/common/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
apollo-common/src/main/java/com/ctrip/framework/apollo/common/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
apollo-common/src/main/java/com/ctrip/framework/apollo/common/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
apollo-common/src/main/java/com/ctrip/framework/apollo/common/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
nobodyiam
reviewed
Sep 5, 2022
apollo-openapi/src/main/java/com/ctrip/framework/apollo/openapi/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
nobodyiam
reviewed
Sep 7, 2022
...-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/url/OpenApiPathBuilder.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/ctrip/framework/apollo/openapi/client/service/ItemOpenApiServiceTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/ctrip/framework/apollo/openapi/client/service/ItemOpenApiServiceTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/ctrip/framework/apollo/openapi/client/service/ItemOpenApiServiceTest.java
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/ItemService.java
Outdated
Show resolved
Hide resolved
apollo-openapi/src/main/java/com/ctrip/framework/apollo/openapi/utils/UrlUtils.java
Show resolved
Hide resolved
nobodyiam
reviewed
Sep 9, 2022
apollo-openapi/src/test/java/com/ctrip/framework/apollo/openapi/client/utils/UrlUtilsTest.java
Outdated
Show resolved
Hide resolved
apollo-openapi/src/test/java/com/ctrip/framework/apollo/openapi/client/utils/UrlUtilsTest.java
Outdated
Show resolved
Hide resolved
nobodyiam
approved these changes
Sep 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
fix openapi item with url illegalKey 400 error
Which issue(s) this PR fixes:
Fixes #4447
Brief changelog
get/update/delete the item key with / \ or start with . will encode key by encodeItems API, otherwise, it will act like old way.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.