Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Simplify code #4524

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Refactor: Simplify code #4524

merged 1 commit into from
Aug 19, 2022

Conversation

mghio
Copy link
Contributor

@mghio mghio commented Aug 16, 2022

What's the purpose of this PR

Simplify code.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #4524 (bd735c0) into master (dfbffe5) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #4524      +/-   ##
============================================
- Coverage     53.45%   53.43%   -0.03%     
- Complexity     2706     2707       +1     
============================================
  Files           492      492              
  Lines         15393    15390       -3     
  Branches       1595     1596       +1     
============================================
- Hits           8229     8223       -6     
- Misses         6606     6607       +1     
- Partials        558      560       +2     
Impacted Files Coverage Δ
...apollo/spring/annotation/SpringValueProcessor.java 81.69% <ø> (ø)
...o/spring/annotation/ApolloAnnotationProcessor.java 91.17% <69.23%> (-1.90%) ⬇️
...work/apollo/spring/annotation/ApolloProcessor.java 100.00% <100.00%> (ø)
.../apollo/internals/RemoteConfigLongPollService.java 77.84% <0.00%> (-0.60%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit e05baf6 into apolloconfig:master Aug 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants