-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle serialization mode to json for compatibility with spring-security version updates #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md
…json for compatibility with spring-security version updates
Codecov Report
@@ Coverage Diff @@
## master #4484 +/- ##
============================================
- Coverage 53.52% 53.48% -0.05%
- Complexity 2702 2704 +2
============================================
Files 489 490 +1
Lines 15325 15343 +18
Branches 1596 1596
============================================
+ Hits 8203 8206 +3
- Misses 6565 6580 +15
Partials 557 557
Help us with your feedback. Take ten seconds to tell us how you rate us. |
nobodyiam
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Switching
spring-session
serialization mode to json for compatibility withspring-security
version updatesWhen the current version upgrades
spring-boot
, it may also upgradespring-security
, which will trigger a version compatibility issue withspring-security
, throwing the following exception:UI error reporting: