feature(openapi): Add a new API to load items with pagination #4468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4468 +/- ##
============================================
- Coverage 53.58% 53.56% -0.02%
- Complexity 2692 2698 +6
============================================
Files 488 489 +1
Lines 15229 15281 +52
Branches 1587 1587
============================================
+ Hits 8160 8186 +26
- Misses 6513 6540 +27
+ Partials 556 555 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
nobodyiam
requested changes
Jul 17, 2022
...service/src/main/java/com/ctrip/framework/apollo/adminservice/controller/ItemController.java
Outdated
Show resolved
Hide resolved
...napi/src/main/java/com/ctrip/framework/apollo/openapi/client/service/ItemOpenApiService.java
Outdated
Show resolved
Hide resolved
apollo-openapi/src/main/java/com/ctrip/framework/apollo/openapi/dto/OpenPageDTO.java
Show resolved
Hide resolved
nobodyiam
reviewed
Jul 17, 2022
There was a problem hiding this comment.
Great! Please also update the CHANGES.md and open api documentations( zh, en )
Done. |
Anilople
reviewed
Jul 17, 2022
...napi/src/main/java/com/ctrip/framework/apollo/openapi/client/service/ItemOpenApiService.java
Outdated
Show resolved
Hide resolved
apollo-openapi/src/main/java/com/ctrip/framework/apollo/openapi/dto/OpenPageDTO.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/ctrip/framework/apollo/openapi/client/service/ItemOpenApiServiceTest.java
Show resolved
Hide resolved
nobodyiam
reviewed
Jul 18, 2022
|
@mghio please help to resolve the conflict. |
Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Add a new API to load items with pagination.
Which issue(s) this PR fixes:
Fixes #4320
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.