Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:compare config #4459

Merged
merged 11 commits into from
Jul 15, 2022
Merged

Conversation

falser101
Copy link
Member

@falser101 falser101 commented Jul 13, 2022

Signed-off-by: jianfei.zhang [email protected]

What's the purpose of this PR

Feature: compare config can search key

Which issue(s) this PR fixes:

Fixes #2663

@falser101 falser101 changed the title Feature:compare config feature:compare config Jul 13, 2022
@falser101 falser101 force-pushed the feature/compare-config branch from c93466b to e295766 Compare July 13, 2022 13:06
@nobodyiam
Copy link
Member

This looks nice to me. Please also update the CHANGES.md.

Signed-off-by: jianfei.zhang <[email protected]>
@falser101
Copy link
Member Author

This looks nice to me. Please also update the CHANGES.md.

updated

@codecov-commenter
Copy link

Codecov Report

Merging #4459 (49daa0c) into master (3440475) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4459      +/-   ##
============================================
+ Coverage     53.54%   53.55%   +0.01%     
+ Complexity     2692     2690       -2     
============================================
  Files           488      488              
  Lines         15229    15229              
  Branches       1587     1587              
============================================
+ Hits           8154     8156       +2     
+ Misses         6518     6515       -3     
- Partials        557      558       +1     
Impacted Files Coverage Δ
...rk/apollo/spring/property/SpringValueRegistry.java 83.78% <0.00%> (-5.41%) ⬇️
...nfigservice/service/AccessKeyServiceWithCache.java 82.65% <0.00%> (-2.05%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 87.71% <0.00%> (-1.76%) ⬇️
...work/apollo/biz/message/ReleaseMessageScanner.java 85.52% <0.00%> (+2.63%) ⬆️
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (+7.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3440475...49daa0c. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit afad056 into apolloconfig:master Jul 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2022
@falser101 falser101 added the feature Categorizes issue as related to a new feature. label Jul 28, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Categorizes issue as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

比较配置功能希望只列出有差异的配置项
3 participants