-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:compare config #4459
feature:compare config #4459
Conversation
Signed-off-by: jianfei.zhang [email protected]
Signed-off-by: jianfei.zhang [email protected]
Signed-off-by: jianfei.zhang <[email protected]>
Signed-off-by: jianfei.zhang <[email protected]>
Signed-off-by: jianfei.zhang <[email protected]>
c93466b
to
e295766
Compare
This looks nice to me. Please also update the CHANGES.md. |
Signed-off-by: jianfei.zhang <[email protected]>
updated |
Codecov Report
@@ Coverage Diff @@
## master #4459 +/- ##
============================================
+ Coverage 53.54% 53.55% +0.01%
+ Complexity 2692 2690 -2
============================================
Files 488 488
Lines 15229 15229
Branches 1587 1587
============================================
+ Hits 8154 8156 +2
+ Misses 6518 6515 -3
- Partials 557 558 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: jianfei.zhang [email protected]
What's the purpose of this PR
Feature: compare config can search key
Which issue(s) this PR fixes:
Fixes #2663