Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the UI experience of open platform authorization management #4436

Merged
merged 57 commits into from
Jul 6, 2022

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Jul 1, 2022

What's the purpose of this PR

Optimize the UI experience of open platform authorization management.
It mainly adds a list page of third-party applications, displays existing third-party applications, and provides the same paging function as configuration management. The specific functions are as follows:

image

image

image

klboke and others added 30 commits May 16, 2019 11:07
@lepdou
Copy link
Contributor

lepdou commented Jul 2, 2022

@klboke It's great.

Having a filter function will be more useful?

image

@klboke
Copy link
Contributor Author

klboke commented Jul 3, 2022

Retrieval is a nice feature. However, in terms of business logic, third-party applications should not be created too much. Then because I didn't think clearly, whether to do front-end retrieval or back-end retrieval. Therefore, this version will not have this function for now. I will consider adding it after seeing the feedback from the community.

@lepdou
Copy link
Contributor

lepdou commented Jul 4, 2022

this version will not have this function for now. I will consider adding it after seeing the feedback from the community.

It's ok~

@klboke klboke requested review from nobodyiam and lepdou July 5, 2022 02:42
nobodyiam
nobodyiam previously approved these changes Jul 6, 2022
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apollo-portal/src/main/resources/static/i18n/en.json Outdated Show resolved Hide resolved
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klboke klboke merged commit 5ab705d into apolloconfig:master Jul 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants