Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Spring-Security Firewall Deny Request Response 400 #4428

Merged
merged 35 commits into from
Jun 28, 2022

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Jun 27, 2022

What's the purpose of this PR

  • Before modification.
    Requesting a service using a non-compliant URL specification returns 500 and the server side reports an exception, e.g.

image

  • After modification.
    Return 400 , e.g.

image

This scenario is more appropriate to use Bad Request (400), in our production environment, because of this problem, the gateway layer alerts often misreported Apollo Server exceptions

klboke and others added 30 commits May 16, 2019 11:07
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #4428 (09ecf07) into master (b8c795a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4428      +/-   ##
============================================
- Coverage     53.42%   53.42%   -0.01%     
  Complexity     2688     2688              
============================================
  Files           490      490              
  Lines         15254    15255       +1     
  Branches       1586     1586              
============================================
  Hits           8150     8150              
- Misses         6548     6549       +1     
  Partials        556      556              
Impacted Files Coverage Δ
...ip/framework/apollo/common/ApolloCommonConfig.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c795a...09ecf07. Read the comment docs.

@klboke klboke requested a review from nobodyiam June 27, 2022 09:29
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit e0938a3 into apolloconfig:master Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants