-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Spring-Security Firewall Deny Request Response 400 #4428
Conversation
# Conflicts: # README.md
Codecov Report
@@ Coverage Diff @@
## master #4428 +/- ##
============================================
- Coverage 53.42% 53.42% -0.01%
Complexity 2688 2688
============================================
Files 490 490
Lines 15254 15255 +1
Branches 1586 1586
============================================
Hits 8150 8150
- Misses 6548 6549 +1
Partials 556 556
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
Requesting a service using a non-compliant URL specification returns 500 and the server side reports an exception, e.g.
Return 400 , e.g.
This scenario is more appropriate to use Bad Request (400), in our production environment, because of this problem, the gateway layer alerts often misreported Apollo Server exceptions