Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor Functions class with lambda #4419

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

Anthony-Lu
Copy link
Contributor

refactor Functions class with lambda

@github-actions
Copy link

github-actions bot commented Jun 16, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Anthony-Lu
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@codecov-commenter
Copy link

Codecov Report

Merging #4419 (903b413) into master (9b1cd8f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4419      +/-   ##
============================================
- Coverage     53.37%   53.34%   -0.03%     
+ Complexity     2684     2683       -1     
============================================
  Files           490      490              
  Lines         15252    15245       -7     
  Branches       1586     1586              
============================================
- Hits           8141     8133       -8     
- Misses         6552     6553       +1     
  Partials        559      559              
Impacted Files Coverage Δ
...trip/framework/apollo/util/function/Functions.java 100.00% <100.00%> (ø)
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0.00%> (-8.34%) ⬇️
...o/openapi/filter/ConsumerAuthenticationFilter.java 94.11% <0.00%> (-5.89%) ⬇️
...nfigservice/service/AccessKeyServiceWithCache.java 82.65% <0.00%> (-2.05%) ⬇️
...ework/apollo/internals/RemoteConfigRepository.java 87.73% <0.00%> (+2.45%) ⬆️
...work/apollo/biz/message/ReleaseMessageScanner.java 85.52% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1cd8f...903b413. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit b73204a into apolloconfig:master Jun 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants