Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cat-client as optional dependency #4414

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Conversation

lorgine-li
Copy link

通过在apollo-core 模块中,通过provided的方式引入cat-client,这样子可以在core模块中去掉cat相关的反射调用。同时还可以解决由于反射导致的cat 客户端上报心跳多次的问题。

@lorgine-li
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

changes/changes-2.1.0.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #4414 (877fa73) into master (1c4b38e) will increase coverage by 0.14%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4414      +/-   ##
============================================
+ Coverage     53.22%   53.37%   +0.14%     
  Complexity     2683     2683              
============================================
  Files           490      490              
  Lines         15300    15252      -48     
  Branches       1586     1586              
============================================
- Hits           8144     8140       -4     
+ Misses         6603     6558      -45     
- Partials        553      554       +1     
Impacted Files Coverage Δ
...pollo/tracer/internals/cat/CatMessageProducer.java 10.00% <0.00%> (+10.00%) ⬆️
...rk/apollo/tracer/internals/cat/CatTransaction.java 0.00% <0.00%> (ø)
...ework/apollo/internals/RemoteConfigRepository.java 85.27% <0.00%> (-3.07%) ⬇️
...racer/internals/DefaultMessageProducerManager.java 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4b38e...877fa73. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 9b1cd8f into apolloconfig:master Jun 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants