Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc changes #4343

Merged
merged 2 commits into from
May 7, 2022
Merged

Misc changes #4343

merged 2 commits into from
May 7, 2022

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented May 7, 2022

What's the purpose of this PR

Misc changes

Which issue(s) this PR fixes:

Brief changelog

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

Codecov Report

Merging #4343 (b83041f) into master (4e000c5) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4343      +/-   ##
============================================
- Coverage     53.21%   53.20%   -0.02%     
  Complexity     2673     2673              
============================================
  Files           489      489              
  Lines         15267    15267              
  Branches       1576     1576              
============================================
- Hits           8125     8123       -2     
- Misses         6589     6593       +4     
+ Partials        553      551       -2     
Impacted Files Coverage Δ
...llo/portal/controller/ConfigsExportController.java 18.51% <ø> (ø)
...llo/portal/controller/ConfigsImportController.java 14.28% <ø> (ø)
...framework/apollo/openapi/entity/ConsumerAudit.java 42.42% <0.00%> (-6.07%) ⬇️
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (-4.69%) ⬇️
...mework/apollo/openapi/service/ConsumerService.java 53.38% <0.00%> (-1.70%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
...work/apollo/biz/message/DatabaseMessageSender.java 64.58% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e000c5...b83041f. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit f183e10 into apolloconfig:master May 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants