Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update secret access key tips #4339

Merged
merged 1 commit into from
May 7, 2022

Conversation

weiyichao
Copy link
Contributor

@weiyichao weiyichao commented May 7, 2022

What's the purpose of this PR

When the apollo version is upgraded to 1.9.0 and above, the secret key configuration variable is changed, APOLLO_ACCESSKEY_SECRET is changed to APOLLO_ACCESS_KEY_SECRET, apollo.accesskey.secret is changed to apollo.access-key.secret. When the apollo server is upgraded to 1.9.0+ and the apollo client is Using the version below 1.9.0, using the variables provided by the tips above 1.9.0 will cause the key variable to be inapplicable.For better use, we need to modify the contents of the Tips.

the original tips:

image

the modified tips:

image

Brief changelog

update secret access key tips

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented May 7, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@weiyichao
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@nisiyong
Copy link
Member

nisiyong commented May 7, 2022

After merging PR #3754, I think the access key tips mislead some users who use the apollo java client version in [1.6.0, 1.9.0).

This PR looks good to me.

@codecov-commenter
Copy link

Codecov Report

Merging #4339 (68206a8) into master (4e000c5) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4339      +/-   ##
============================================
- Coverage     53.21%   53.17%   -0.05%     
+ Complexity     2673     2672       -1     
============================================
  Files           489      489              
  Lines         15267    15267              
  Branches       1576     1576              
============================================
- Hits           8125     8118       -7     
- Misses         6589     6597       +8     
+ Partials        553      552       -1     
Impacted Files Coverage Δ
...framework/apollo/openapi/entity/ConsumerAudit.java 42.42% <0.00%> (-6.07%) ⬇️
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (-4.69%) ⬇️
...ework/apollo/internals/RemoteConfigRepository.java 85.27% <0.00%> (-3.07%) ⬇️
...mework/apollo/openapi/service/ConsumerService.java 53.38% <0.00%> (-1.70%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
...work/apollo/biz/message/DatabaseMessageSender.java 64.58% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e000c5...68206a8. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 74225fd into apolloconfig:master May 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants