Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc changes #4333

Merged
merged 1 commit into from
May 2, 2022
Merged

Misc changes #4333

merged 1 commit into from
May 2, 2022

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Misc changes

Which issue(s) this PR fixes:

Fixes #2463

Brief changelog

  1. Upgrade maven plugin versions to fix error in Java 17
  2. Fix potential issue in consumer management

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

1. Upgrade maven plugin versions to fix error in Java 17
2. Fix potential issue in consumer management
@codecov-commenter
Copy link

Codecov Report

Merging #4333 (341cc00) into master (66c826d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4333      +/-   ##
============================================
- Coverage     53.21%   53.20%   -0.02%     
+ Complexity     2674     2673       -1     
============================================
  Files           489      489              
  Lines         15267    15267              
  Branches       1576     1576              
============================================
- Hits           8125     8123       -2     
- Misses         6587     6593       +6     
+ Partials        555      551       -4     
Impacted Files Coverage Δ
...k/apollo/portal/controller/ConsumerController.java 11.42% <ø> (ø)
...framework/apollo/openapi/entity/ConsumerAudit.java 42.42% <0.00%> (-6.07%) ⬇️
...nfigservice/service/AccessKeyServiceWithCache.java 82.65% <0.00%> (-2.05%) ⬇️
...mework/apollo/openapi/service/ConsumerService.java 53.38% <0.00%> (-1.70%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) ⬆️
...rk/apollo/spring/property/SpringValueRegistry.java 89.18% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c826d...341cc00. Read the comment docs.

@nobodyiam nobodyiam merged commit 4e000c5 into apolloconfig:master May 2, 2022
@nobodyiam nobodyiam deleted the misc-changes branch May 2, 2022 06:36
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven打包是出错Error injecting: org.codehaus.plexus.archiver.zip.ZipArchiver
4 participants