Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of Apollo Official Chinese Document(s) #4322

Merged
merged 3 commits into from
Apr 26, 2022

Conversation

misselvexu
Copy link
Contributor

What's the purpose of this PR

Translation of Apollo Official Chinese Document(s)

Which issue(s) this PR fixes:

Fixes #3541

Brief changelog

none

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Apr 24, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@misselvexu
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! Great job!
However, there are some link and anchor issues, which I pointed out some. Would you please help to find out and fix them? I understand it would involve more work to do, but I think it's valueable as it helps the users to find the relevant information easily.

docs/en/design/apollo-introduction.md Outdated Show resolved Hide resolved
docs/en/deployment/distributed-deployment-guide.md Outdated Show resolved Hide resolved
docs/en/deployment/distributed-deployment-guide.md Outdated Show resolved Hide resolved
docs/en/deployment/distributed-deployment-guide.md Outdated Show resolved Hide resolved
docs/en/deployment/distributed-deployment-guide.md Outdated Show resolved Hide resolved
docs/en/deployment/distributed-deployment-guide.md Outdated Show resolved Hide resolved
docs/en/deployment/distributed-deployment-guide.md Outdated Show resolved Hide resolved
docs/en/deployment/distributed-deployment-guide.md Outdated Show resolved Hide resolved
docs/en/usage/apollo-user-guide.md Outdated Show resolved Hide resolved
docs/en/usage/apollo-user-guide.md Outdated Show resolved Hide resolved
@misselvexu
Copy link
Contributor Author

This looks fantastic! Great job! However, there are some link and anchor issues, which I pointed out some. Would you please help to find out and fix them? I understand it would involve more work to do, but I think it's valueable as it helps the users to find the relevant information easily.

Thanks for the help Review, will take the time to gradually optimize and fix job.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the Apollo Security Best Practices link in _sidebar.md.

image

docs/en/README.md Outdated Show resolved Hide resolved
docs/en/design/apollo-design.md Outdated Show resolved Hide resolved
docs/en/design/apollo-design.md Outdated Show resolved Hide resolved
docs/en/design/apollo-introduction.md Outdated Show resolved Hide resolved
docs/en/design/apollo-introduction.md Outdated Show resolved Hide resolved
@misselvexu
Copy link
Contributor Author

Please also fix the Apollo Security Best Practices link in _sidebar.md.

image

Thanks for your help with the Review code, the issues mentioned in the Review above have been fixed and initially tested locally with jekyll.

@nobodyiam
Copy link
Member

@misselvexu

Thanks for your kind effort, this pr really helps the apollo community a lot!

BTW, the documentation site could be tested locally via docsify serve docs command.

@codecov-commenter
Copy link

Codecov Report

Merging #4322 (2e5689b) into master (49028e8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4322   +/-   ##
=========================================
  Coverage     53.21%   53.21%           
  Complexity     2674     2674           
=========================================
  Files           489      489           
  Lines         15267    15267           
  Branches       1576     1576           
=========================================
  Hits           8125     8125           
  Misses         6587     6587           
  Partials        555      555           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49028e8...2e5689b. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 52f0084 into apolloconfig:master Apr 26, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Apr 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate Chinese document into English
3 participants