Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flyway from 5 2 4 to 8 0 5 #4312

Merged

Conversation

hezhangjian
Copy link
Member

What's the purpose of this PR

update the flyway version to corresponding spring-cloud dependency version

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@hezhangjian hezhangjian force-pushed the update-flyway-from-5-2-4-to-8-0-5 branch from 7070f35 to c4b8642 Compare April 12, 2022 13:31
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #4312 (c4b8642) into master (a882f3e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4312   +/-   ##
=========================================
  Coverage     53.17%   53.17%           
  Complexity     2668     2668           
=========================================
  Files           488      488           
  Lines         15253    15253           
  Branches       1577     1577           
=========================================
  Hits           8111     8111           
  Misses         6587     6587           
  Partials        555      555           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a882f3e...c4b8642. Read the comment docs.

@nobodyiam
Copy link
Member

It seems the new flyway-maven-plugin doesn't work in my environment, but the old version(5.2.4) works with no problem.

Run the mvn -N -Pconfigdb flyway:migrate and got this result:

[ERROR] Failed to execute goal org.flywaydb:flyway-maven-plugin:8.0.5:migrate (default-cli) on project apollo: org.flywaydb.core.api.FlywayException: Unable to connect to the database. Configure the url, user and password! -> [Help 1]

flyway-configdb.properties

flyway.user=root
flyway.password=
flyway.schemas=ApolloConfigDB
flyway.url=jdbc:mysql://localhost:3306?useSSL=false&characterEncoding=utf8
flyway.locations=filesystem:scripts/flyway/configdb

MySQL version: 8.0.28

@hezhangjian hezhangjian force-pushed the update-flyway-from-5-2-4-to-8-0-5 branch from c4b8642 to b0b0691 Compare April 13, 2022 03:20
@hezhangjian hezhangjian force-pushed the update-flyway-from-5-2-4-to-8-0-5 branch from b0b0691 to 96b069a Compare April 13, 2022 03:20
@hezhangjian
Copy link
Member Author

@nobodyiam My bad, please take a look again. test with mysql 8.0.27

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit a42b793 into apolloconfig:master Apr 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2022
@hezhangjian hezhangjian deleted the update-flyway-from-5-2-4-to-8-0-5 branch April 13, 2022 04:23
@nobodyiam nobodyiam added this to the 2.0.0 milestone May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants