Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: javax.net.ssl.SSLHandshakeException: No appropriate protocol #4308

Merged
merged 3 commits into from
Apr 10, 2022

Conversation

Anilople
Copy link
Contributor

@Anilople Anilople commented Apr 9, 2022

What's the purpose of this PR

Let user doesn't need add useSSL=false to spring.datasource.url's value

Which issue(s) this PR fixes:

Fixes #4300 (comment)

Brief changelog

upgrade mysql-connector-java version from 8.0.16 to 8.0.28

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #4308 (22983c8) into master (ba94759) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4308      +/-   ##
============================================
+ Coverage     53.15%   53.17%   +0.02%     
- Complexity     2665     2668       +3     
============================================
  Files           488      488              
  Lines         15253    15253              
  Branches       1577     1577              
============================================
+ Hits           8107     8111       +4     
+ Misses         6593     6587       -6     
- Partials        553      555       +2     
Impacted Files Coverage Δ
...rk/apollo/spring/property/SpringValueRegistry.java 83.78% <0.00%> (-5.41%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 87.71% <0.00%> (-1.76%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (+1.17%) ⬆️
...mework/apollo/openapi/service/ConsumerService.java 55.08% <0.00%> (+1.69%) ⬆️
...nfigservice/service/AccessKeyServiceWithCache.java 84.69% <0.00%> (+2.04%) ⬆️
...framework/apollo/openapi/entity/ConsumerAudit.java 48.48% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba94759...22983c8. Read the comment docs.

@nobodyiam nobodyiam merged commit a882f3e into apolloconfig:master Apr 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants