Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use item.isDeleted to check whether the item is deleted #4279

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Use item.isDeleted to check whether the item is deleted, as item.dataChangeLastModifiedBy is not null for deleted items since #2680.

Which issue(s) this PR fixes:

Fixes #4276

Brief changelog

  • Use item.isDeleted to check whether the item is deleted

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nobodyiam nobodyiam requested a review from a team March 26, 2022 12:02
@codecov-commenter
Copy link

Codecov Report

Merging #4279 (bb0d07d) into master (8d623d5) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4279      +/-   ##
============================================
+ Coverage     52.56%   52.59%   +0.03%     
- Complexity     2641     2642       +1     
============================================
  Files           488      488              
  Lines         15253    15253              
  Branches       1577     1577              
============================================
+ Hits           8017     8022       +5     
+ Misses         6685     6681       -4     
+ Partials        551      550       -1     
Impacted Files Coverage Δ
...ework/apollo/internals/RemoteConfigRepository.java 88.34% <0.00%> (+3.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d623d5...bb0d07d. Read the comment docs.

Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 63e959f into apolloconfig:master Mar 27, 2022
@nobodyiam nobodyiam deleted the fix-4276 branch March 27, 2022 00:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants