Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize create namespace page #4213

Merged

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Jan 20, 2022

What's the purpose of this PR

Which issue(s) this PR fixes:

optimize create namespace page

Brief changelog

change list

  1. adjust form field order
  2. make create namespace as default action
  3. make create private namespace as default type

old page

image

new page

image

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

Codecov Report

Merging #4213 (a8eaecc) into master (79d9005) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4213   +/-   ##
=========================================
  Coverage     52.55%   52.56%           
- Complexity     2631     2632    +1     
=========================================
  Files           485      485           
  Lines         15225    15225           
  Branches       1573     1573           
=========================================
+ Hits           8002     8003    +1     
+ Misses         6667     6666    -1     
  Partials        556      556           
Impacted Files Coverage Δ
...nfigservice/filter/ClientAuthenticationFilter.java 93.61% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d9005...a8eaecc. Read the comment docs.

@nobodyiam
Copy link
Member

I'm okay with this change then.
BTW, does it look better if we align the create namespace tab with the appid?

image

image

@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 23, 2022
@lepdou
Copy link
Contributor Author

lepdou commented Jan 24, 2022

I have fixed it.

image

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit b6237bb into apolloconfig:master Jan 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants